Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rollup .mjs extension #309

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Fix rollup .mjs extension #309

merged 2 commits into from
Dec 14, 2023

Conversation

nihalgonsalves
Copy link
Contributor

@nihalgonsalves nihalgonsalves commented Dec 14, 2023

I had a typo in #308 and 6.1.0's1 ESM build is broken, sorry!

There was a .js extension instead of .mjs. I had amended the commit and forgot to push it to the PR, so the diff in the PR was from the correct version. This is the fix!

Footnotes

  1. https://github.com/yhatt/jsx-slack/releases/tag/v6.1.0

Copy link
Owner

@yhatt yhatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm going to release again.

@yhatt yhatt merged commit c85ecaa into yhatt:main Dec 14, 2023
7 checks passed
@nihalgonsalves nihalgonsalves deleted the ng/fix-rollup-esm-output branch December 14, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants